Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request generator - Bitbucket cloud support #11273

Closed
Jamess-Lucass opened this issue Nov 11, 2022 · 0 comments · Fixed by #11275
Closed

Pull request generator - Bitbucket cloud support #11273

Jamess-Lucass opened this issue Nov 11, 2022 · 0 comments · Fixed by #11275
Labels
enhancement New feature or request

Comments

@Jamess-Lucass
Copy link
Contributor

Jamess-Lucass commented Nov 11, 2022

Summary

Same enhancement as #10695 with a slightly different proposal following ideas from #11150 and the existing implementation for bitbucket-server referenced in the docs here

What change you think needs making.

Motivation

A lot of users, including myself, use the cloud version of bitbucket and would benefit from being able to utilize the pull request generator feature provided by Argo CD.

Proposal

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: myapps
spec:
  generators:
    - pullRequest:
        bitbucket:
          # Workspace name where the repoistory is stored under. Required.
          owner: myproject
          # Repository slug. Required.
          repo: myrepository
          # URL of the Bitbucket Cloud API. (optional) Will default to 'https://api.bitbucket.org/2.0'.
          api: https://api.bitbucket.org/2.0
          # Credentials for Basic authentication. Required for private repositories.
          basicAuth:
            # The username to authenticate with
            username: myuser
            # Reference to a Secret containing the password or personal access token.
            passwordRef:
              secretName: mypassword
              key: password
        # Labels are not supported by Bitbucket Cloud, so filtering by label is not possible.
        # Filter PRs using the source branch name. (optional)
        filters:
          - branchMatch: ".*-argocd"
  template:
  # ...

Named bitbucket to keep aligned to how the scmProvider is named in #11150

  • owner (required) could be named several different things, possibly workspace to follow the naming in Bitbucket Cloud REST API docs

  • api (optional) is the base url for where the pull requests are queried from - In most cases this will remain https://api.bitbucket.org/2.0 and if the api is not set or left blank, it will default back to https://api.bitbucket.org/2.0

  • basicAuth (optional) is to support authenticating to private bitbucket cloud repositories

@Jamess-Lucass Jamess-Lucass added the enhancement New feature or request label Nov 11, 2022
@Jamess-Lucass Jamess-Lucass changed the title Pull request generator - bitbucket cloud support Pull request generator - Bitbucket cloud support Nov 11, 2022
crenshaw-dev added a commit that referenced this issue Jun 26, 2023
#11273) (#11275)

* feat(pull-requests): Added Bitbucket Cloud support for pull request generator

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>

* fixes from review

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
argoproj#11273) (argoproj#11275)

* feat(pull-requests): Added Bitbucket Cloud support for pull request generator

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>

* fixes from review

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
argoproj#11273) (argoproj#11275)

* feat(pull-requests): Added Bitbucket Cloud support for pull request generator

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>

* fixes from review

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Jamess-Lucass <jameslucas1210@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant