Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for custom styles to use sidebar class #11714

Open
fty4 opened this issue Dec 15, 2022 · 2 comments · May be fixed by #11733
Open

Update docs for custom styles to use sidebar class #11714

fty4 opened this issue Dec 15, 2022 · 2 comments · May be fixed by #11733
Labels
component:docs enhancement New feature or request

Comments

@fty4
Copy link
Contributor

fty4 commented Dec 15, 2022

Description

The UI of Argo CD changed where no .nav-bar class is present anymore.
In the new release the class changed to .sidebar.

The documentation still has the old implementation referenced to modify the menu color which can be changed optionally.

The documentation here should be fixed and changed to reference the new sidebar class.

The old color suggestions might not be the best (linear-gradient does not match with Argo CD style anymore?).
I would suggest to change it as in this commit here:

fty4@e853963

Do you agree? Or how should this be changed?


original Argo CD style

Screenshot 2022-12-15 at 10 58 29

Only class change

.sidebar {
  background: linear-gradient(to bottom, #999, #777, #333, #222, #111);
}

Screenshot 2022-12-15 at 10 59 52

class and color change

.sidebar {
  background-color: #444;
}

Screenshot 2022-12-15 at 11 03 25

@fty4 fty4 added the enhancement New feature or request label Dec 15, 2022
@saumeya
Copy link
Contributor

saumeya commented Dec 16, 2022

Thanks for opening the issue @fty4 , Would you like to contribute these changes to the doc?

@fty4 fty4 linked a pull request Dec 16, 2022 that will close this issue
10 tasks
@fty4
Copy link
Contributor Author

fty4 commented Dec 16, 2022

@saumeya I've created a PR (#11733)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants