docs: use class sidebar instead of nav-bar (#11714) #11733
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11733 +/- ##
==========================================
- Coverage 49.25% 49.25% -0.01%
==========================================
Files 251 251
Lines 43521 43521
==========================================
- Hits 21438 21435 -3
- Misses 19949 19951 +2
- Partials 2134 2135 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI of Argo CD changed where no
.nav-barclass is present anymore.In the new release the class changed to
.sidebar.The documentation still has the old implementation referenced to modify the menu color which can be changed optionally.
The documentation here should be fixed and changed to reference the new
sidebarclass.closes #11714
Checklist:
I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.Does this PR require documentation updates?I've updated documentation as required by this PR.I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.My build is green (troubleshooting builds).Marco Lecheler marco.lecheler@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)