bug(ui): Resource Kind NodeGroup is not aligned

[speedfl]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

When using a resource Kind NodeGroup (ie: ACK Controller NodeGroup), the UI is adding an extra 25px padding top

The issue come from the fact that any object suffixed by --nodegroup has an extra 25px

argo-cd/ui/src/app/applications/components/application-resource-tree/application-resource-tree.scss

Line 153 in 5d3bdb5

&--nodegroup{

argo-cd/ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx

Line 744 in 5d3bdb5

function renderResourceNode(props: ApplicationResourceTreeProps, id: string, node: ResourceTreeNode & dagre.Node, nodesHavingChildren: Map<string, number>) {

Issue that introduce this feature: #12089

To Reproduce

Deploy the ACK controller EKS: https://github.com/aws-controllers-k8s/eks-controller/tree/main

Create a resource NodeGroup

Expected behavior

Must be aligned

Screenshots

Version

All

[cclp94]

I'll prepare a PR for this. I think in renderResourceNode we could add a new css class for resource nodes only that overwrites the padding

[keithchong]

I'm wondering if we can just get rid of the nodegroup style from the scss file, since it seems to only affect the nodegroup resource kind.

cc @ashutosh16

[speedfl]

Node group is also used to group the nodes like pod group I guess

[cclp94]

I finally had the time to deep into this. I think @keithchong is right. A "Grouped Node" would pass by another function renderGroupedNodes() which doesn't add the 'application-resource-tree__node--' + node.kind.toLowerCase(), class like the renderResourceNode() does. Therefore, it looks safe to just remove it.