-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): Tree view groups node by heath status #12089
Conversation
b9d08c9
to
661d990
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12089 +/- ##
=======================================
Coverage 49.02% 49.03%
=======================================
Files 247 247
Lines 42692 42694 +2
=======================================
+ Hits 20928 20933 +5
+ Misses 19647 19645 -2
+ Partials 2117 2116 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
b0a3505
to
f1bf2ea
Compare
f1bf2ea
to
0fb6d68
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
8c32ff1
to
f912276
Compare
7bfed77
to
49dc3d1
Compare
8f5ced1
to
8586ccf
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
3a5e533
to
de9b929
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> lint Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> pod group to default view Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
de9b929
to
8045756
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
Screen.Recording.2023-03-20.at.10.11.51.AM.mov |
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@keithchong As you suggested, I have modified the label. Kindly review the changes |
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashutosh16 , run the lint to resolve the failing PR check.
There are still fit-and-finish changes but these can be done in a follow-on PR.
Other than these, LGTM
Hi @rbreeze , for your awareness. Could you also approve this? |
@rbreeze can you take a quick look into the PR, and let me if the PR can be merged? |
Hi @ashutosh16, from the screenshots I have a couple minor suggestions, but I'd like to test a live version. What repository did you use to create the Application you used in testing? |
@rbreeze I've used repo for creating rollout app. However, you can use guestbook app and increase the pods' count > 15, once you increase the count you will be able to see the changes |
ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@rbreeze Would you be able to merge the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aslafy-z I'm afraid this feature is too big to backport, but if you want to put up a PR against the release-2.7 branch with just the bug fix, we could merge that! |
Thank you for the quick answer @crenshaw-dev. I opened #14618 to backport the fix. |
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com> Co-authored-by: Remington Breeze <remington@breeze.software>
Checklist: