Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Tree view groups node by heath status #12089

Merged
merged 23 commits into from
Apr 25, 2023

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Jan 23, 2023

  • Group the pods by health status (Healthy, degraded, progressing) when the pods count is greater than 15
  • Set the default view to group node when the pod count is more than 15
  • When UI shows podGrouping, click on the group by health status link that opens the slider which shows the pod by -filter by health (Healthy, degraded, progressing)
  • On clicking on the replica set group - List all the replica set with revision( that contain no pods)
  • On the List view(slider panel) show the parent resource information
  • Highlight the group node icon for the user when UI is switched to the group node view

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@ashutosh16 ashutosh16 force-pushed the tree-view-cluster branch 3 times, most recently from b9d08c9 to 661d990 Compare January 24, 2023 04:07
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (93f8723) 49.02% compared to head (8435ec0) 49.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12089   +/-   ##
=======================================
  Coverage   49.02%   49.03%           
=======================================
  Files         247      247           
  Lines       42692    42694    +2     
=======================================
+ Hits        20928    20933    +5     
+ Misses      19647    19645    -2     
+ Partials     2117     2116    -1     
Impacted Files Coverage Δ
util/helm/helm.go 44.14% <ø> (ø)
controller/appcontroller.go 53.10% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashutosh16 ashutosh16 changed the title Tree view groups node by heath status feat(UI: Tree view groups node by heath status Jan 24, 2023
@ashutosh16 ashutosh16 changed the title feat(UI: Tree view groups node by heath status feat(UI): Tree view groups node by heath status Jan 24, 2023
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16 ashutosh16 marked this pull request as ready for review February 8, 2023 17:47
@ashutosh16
Copy link
Contributor Author

Screen Shot 2023-02-09 at 11 03 03 PM

@ashutosh16 ashutosh16 force-pushed the tree-view-cluster branch 3 times, most recently from 7bfed77 to 49dc3d1 Compare February 27, 2023 05:25
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16 ashutosh16 force-pushed the tree-view-cluster branch 4 times, most recently from 3a5e533 to de9b929 Compare March 17, 2023 05:33
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

lint

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

pod group to default view

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16
Copy link
Contributor Author

Screen.Recording.2023-03-20.at.10.11.51.AM.mov

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16
Copy link
Contributor Author

@keithchong As you suggested, I have modified the label. Kindly review the changes
Screenshot 2023-03-22 at 1 45 06 PM

@ashutosh16 ashutosh16 requested a review from keithchong April 4, 2023 02:06
Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashutosh16 , run the lint to resolve the failing PR check.

There are still fit-and-finish changes but these can be done in a follow-on PR.

Other than these, LGTM

@keithchong keithchong requested a review from rbreeze April 4, 2023 19:13
@keithchong
Copy link
Contributor

Hi @rbreeze , for your awareness. Could you also approve this?

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16
Copy link
Contributor Author

@rbreeze can you take a quick look into the PR, and let me if the PR can be merged?

@rbreeze
Copy link
Member

rbreeze commented Apr 7, 2023

Hi @ashutosh16, from the screenshots I have a couple minor suggestions, but I'd like to test a live version. What repository did you use to create the Application you used in testing?

@ashutosh16
Copy link
Contributor Author

Hi @ashutosh16, from the screenshots I have a couple minor suggestions, but I'd like to test a live version. What repository did you use to create the Application you used in testing?

@rbreeze I've used repo for creating rollout app. However, you can use guestbook app and increase the pods' count > 15, once you increase the count you will be able to see the changes

rbreeze and others added 3 commits April 12, 2023 16:20
@ashutosh16 ashutosh16 requested a review from rbreeze April 17, 2023 17:52
@ashutosh16
Copy link
Contributor Author

@rbreeze Would you be able to merge the PR?

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze merged commit 467777f into argoproj:master Apr 25, 2023
@aslafy-z
Copy link
Contributor

Any chance this gets backported to 2.7? It would fix the following bug:
image

@crenshaw-dev
Copy link
Member

@aslafy-z I'm afraid this feature is too big to backport, but if you want to put up a PR against the release-2.7 branch with just the bug fix, we could merge that!

@aslafy-z
Copy link
Contributor

aslafy-z commented Jul 20, 2023

Thank you for the quick answer @crenshaw-dev. I opened #14618 to backport the fix.

yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants