Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replicas field to ReplicaSet info collection on resource tree #16769

Open
zhammer opened this issue Jan 8, 2024 · 0 comments · May be fixed by #18092
Open

Add replicas field to ReplicaSet info collection on resource tree #16769

zhammer opened this issue Jan 8, 2024 · 0 comments · May be fixed by #18092
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@zhammer
Copy link

zhammer commented Jan 8, 2024

Summary

Curious what the appetite is for adding a replicas field to the ReplicaSet info collection on the resource tree.

Motivation

  1. It'd be helpful when looking at ReplicaSets in the ArgoCD UI to have a quick view of how many replicas are configured for that rs in the form of an info label
  2. Having replicas count info in the resource-tree API would help in allowing tools that ingest from that API to show deployment progress, quickly add up total pod counts, etc.

We realize we can use #11153 for this, duplicating the spec.replicas to a custom label but are curious if it'd make sense to have this as ReplicaSet specific info field, like the Pod-specific info fields (https://github.com/argoproj/argo-cd/blob/40760eb8528766745328e67e124e2cf1f56d8d93/controller/cache/info.go#L281C16-L281C16).

Proposal

Similar to https://github.com/argoproj/argo-cd/blob/40760eb8528766745328e67e124e2cf1f56d8d93/controller/cache/info.go#L281C4-L281C4, have a populateReplicaSetInfo function that adds the replica count to the resource info.

@zhammer zhammer added the enhancement New feature or request label Jan 8, 2024
@zhammer zhammer linked a pull request May 6, 2024 that will close this issue
14 tasks
@reggie-k reggie-k added the component:ui User interfaces bugs and enhancements label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
2 participants