feat: Add replicas info item to ReplicaSet node (#16769)
#16782
Conversation
Signed-off-by: Zach Hammer <zhammer@seatgeek.com>
controller/cache/info.go
Outdated
| func populateReplicaSetInfo(un *unstructured.Unstructured, res *ResourceInfo) { | ||
| replicas, ok, err := unstructured.NestedInt64(un.Object, "spec", "replicas") | ||
| if err == nil && ok { | ||
| res.Info = append(res.Info, v1alpha1.InfoItem{Name: "Replicas", Value: fmt.Sprintf("Replicas:%d", replicas)}) |
There was a problem hiding this comment.
I use Replicas:%d as the value here for a clearer label on the UI. Could also do %d replicas, like the %d days ago label
|
hm, it seems like at least the unit test is broken due to a bug in the yaml library used: kubernetes-sigs/yaml#45 |
Signed-off-by: Zach Hammer <zhammer@seatgeek.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16782 +/- ##
==========================================
+ Coverage 49.25% 49.49% +0.24%
==========================================
Files 274 271 -3
Lines 48170 47845 -325
==========================================
- Hits 23724 23679 -45
+ Misses 22099 21824 -275
+ Partials 2347 2342 -5 ☔ View full report in Codecov by Sentry. |
|
We talked about this today in the argo contributor meeting and there were no objections. |
|
Hi @alexmt - this was 👍’d in the last contributor meeting that you led. Would appreciate a review from a maintainer whenever there is time. Thanks again! |
Signed-off-by: Zach Hammer <zhammer@seatgeek.com>
Signed-off-by: Zach Hammer <zhammer@seatgeek.com>
Rebase from upstream master
change sync strategy for rollback
Set field managers for server side apply
|
closing in favor of #18092 18092 |
Closes #16769 by adding a
Replicasinfo item forReplicaSetnodes.Checklist: