Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add replicas info item to ReplicaSet node (#16769) #16782

Closed
wants to merge 12 commits into from
9 changes: 9 additions & 0 deletions controller/cache/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ func populateNodeInfo(un *unstructured.Unstructured, res *ResourceInfo, customLa
populatePodInfo(un, res)
case kube.ServiceKind:
populateServiceInfo(un, res)
case kube.ReplicaSetKind:
populateReplicaSetInfo(un, res)
case "Node":
populateHostNodeInfo(un, res)
}
Expand Down Expand Up @@ -103,6 +105,13 @@ func populateServiceInfo(un *unstructured.Unstructured, res *ResourceInfo) {
res.NetworkingInfo = &v1alpha1.ResourceNetworkingInfo{TargetLabels: targetLabels, Ingress: ingress, ExternalURLs: urls}
}

func populateReplicaSetInfo(un *unstructured.Unstructured, res *ResourceInfo) {
replicas, ok, err := unstructured.NestedInt64(un.Object, "spec", "replicas")
if err == nil && ok {
res.Info = append(res.Info, v1alpha1.InfoItem{Name: "Replicas", Value: fmt.Sprintf("Replicas:%d", replicas)})
Copy link
Author

@zhammer zhammer Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use Replicas:%d as the value here for a clearer label on the UI. Could also do %d replicas, like the %d days ago label

}
}

func getServiceName(backend map[string]interface{}, gvk schema.GroupVersionKind) (string, error) {
switch gvk.Group {
case "extensions":
Expand Down
16 changes: 16 additions & 0 deletions controller/cache/info_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -753,3 +753,19 @@ func TestManifestHash(t *testing.T) {
assert.Equal(t, expected, hash)
assert.Nil(t, err)
}

func TestReplicaSet(t *testing.T) {
replicaSet := strToUnstructured(`
apiVersion: v1
kind: ReplicaSet
metadata:
name: helm-guestbook
spec:
replicas: 10
`)

info := &ResourceInfo{}
populateNodeInfo(replicaSet, info, []string{})

assert.Contains(t, info.Info, v1alpha1.InfoItem{Name: "Replicas", Value: "Replicas:10"})
}
Loading