'util/git/creds.go' will leak temporary files to '/dev/shm' if proxy URL cannot be parsed, or if write fails

[jgwest]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

In util/git/creds.go, within (c SSHCreds) Environ(), there are a couple of corner cases where the temporary file that is created is not being cleaned up:

• If the socks5 proxy settings URL cannot be parsed by url.Parse, the function will return without deleting the temporary file.
• If a call to file.WriteString fails, the temporary file will not be cleaned up (but, admittedly, this would be very rare)

We've had customer reports of /dev/shm running out of space due to temporary files left hanging around, and I discovered the above issue while auditing Argo CD's use of /dev/shm.

I've submitted a PR which fixes both issues. The solution is the same one used by the other Environ() functions in creds.go

Version

master branch

[manidharanupoju24]

We are seeing some customer issues regarding the same. Hopefully, this PR fixes the same