Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to use different image example for sidecar container #17885

Open
raweber42 opened this issue Apr 18, 2024 · 1 comment
Open
Labels
component:cmp Config Management Plugin related issues component:docs enhancement New feature or request

Comments

@raweber42
Copy link
Contributor

Summary

In the documentation about CMP plugins via sidecar containers, it is recommended (or at least given as example) to use busybox as the image for your sidecar container. This should be changed imho, as this does not work properly if you are trying to install argocd-vault as a plugin. See also here: #13539 (comment)

Motivation

A lot of people are using argocd-vault as a plugin. They should be provided with documentation that works out of the box for their usecase. It has to be an image that includes ca-certificates. Otherwise they will run into the following bug which I ran into myself:

Could not find secret: rpc error: code = Unavailable desc = connection error: desc = \"transport: authentication handshake failed: tls: failed to verify certificate: x509: certificate signed by unknown authority

Proposal

Update the documentation here and here to an image which includes ca-certificates. Or at least add a note for vault-plugin users.

In the vault-plugin documentation they use a different image: https://argocd-vault-plugin.readthedocs.io/en/stable/installation/#initcontainer-and-configuration-via-sidecar

@raweber42 raweber42 added the enhancement New feature or request label Apr 18, 2024
@crenshaw-dev
Copy link
Member

I'd be fine with Ubuntu. I didn't pick Busybox for any particular reason in that example. Would gladly review a docs PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cmp Config Management Plugin related issues component:docs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants