-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace image to one which includes ca-certificates #18068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com>
Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com>
It's my first PR of this kind, feel free to give me some tips on how to improve! |
wanghong230
suggested changes
May 3, 2024
todaywasawesome
requested changes
May 7, 2024
Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
May 10, 2024
todaywasawesome
approved these changes
May 10, 2024
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…8068) * Replace image to include ca-certificates Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update comment Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Dan Garfield <dan@codefresh.io>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…8068) * Replace image to include ca-certificates Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update comment Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Dan Garfield <dan@codefresh.io>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…8068) * Replace image to include ca-certificates Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update comment Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/config-management-plugins.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This PR improves the example given for installing CMP plugins in the documentation. The current image (
busybox
) does not includeca-certificates
, which made the installation fail in my case. This will avoid users from having to debug on a very deep level as I had to. I am open for other image suggestions, of course!Closes [ISSUE #17885]