Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters not showing fields from custom helm values file #8808

Closed
EdwinPhilip opened this issue Mar 17, 2022 · 17 comments · Fixed by #9566
Closed

Parameters not showing fields from custom helm values file #8808

EdwinPhilip opened this issue Mar 17, 2022 · 17 comments · Fixed by #9566
Labels
bug Something isn't working

Comments

@EdwinPhilip
Copy link

Describe the bug

When using helm charts as the source of applications, we intend to have multiple values file targeting each environment, say qa-values.yaml, prod-values.yaml.
Till argo cd version 2.2.5, the Parameters tab shows fields from all the values file chosen, both from the default values file and the overridden custom values file chosen.
With latest 2.3.1, Parameters tab shows only fields from the default values file.

Expected behavior

Parameters tab should show fields from both default values file and overridden values file

Version

argocd: v2.3.1+b65c169
@EdwinPhilip EdwinPhilip added the bug Something isn't working label Mar 17, 2022
@rbabyuk-vs
Copy link

right, we see the same issue. it appeared after upgrade to 2.3.1

@SashaShcherbyna
Copy link

SashaShcherbyna commented Mar 30, 2022

so, after upgrading to 2.3.1 we have the same behavior. With latest 2.3.1, Parameters tab shows only fields from the default values file.

@jlirochon
Copy link

Same on v2.3.2+ecc2af9

Maybe related : when you call GetParameterValueByName in a notification template, app-sync-running in my case, it can only read values from values.yaml.

For example {{ (call .repo.GetAppDetails).Helm.GetParameterValueByName "my_parameter" }} returns the value of my_parameter if it's defined in values.yaml, but returns an empty string if it's defined in say values-staging.yaml

Also {{ (call .repo.GetAppDetails).Helm.ValueFiles }} only returns [values.yaml]

@mblsf
Copy link

mblsf commented Apr 20, 2022

Same issue here, please fix

@mihma
Copy link

mihma commented Apr 27, 2022

Also affected by this issue

@guyelia
Copy link
Contributor

guyelia commented Apr 28, 2022

same here

@burakovsky
Copy link

burakovsky commented May 6, 2022

just add that it appeared in 2.2.6 version

@mihma
Copy link

mihma commented May 15, 2022

Is this issue getting any traction?

@blake-kilraine-ol
Copy link

Hello - we have the same issue. Is anyone familiar with a workaround?

@crenshaw-dev
Copy link
Member

The fix has been cherry-picked into v2.4.0-rc5.

@guitmz
Copy link

guitmz commented Jul 20, 2022

@crenshaw-dev we are running v2.4.7 and the issue is still present (note image.tag for example, it is properly defined inside our values but the default is showing up in the UI and in the GetParameterValueByName method)

image

@crenshaw-dev
Copy link
Member

@guitmz can you elaborate? Where have you set the overriding image.tag that you expect to see?

@guitmz
Copy link

guitmz commented Jul 20, 2022

@crenshaw-dev I have image.tag override defined in values (not values files).

I expect to see my custom override image.tag in the UI (and in GetParameterValueByName) and not the YYYY placeholder default string I have in my chart.

Pretty much the same thing as #9213 and the other issues mentioned in the PR that added the fix.

@crenshaw-dev
Copy link
Member

Thanks @guitmz! I reopened that issue.

@ale-conekta
Copy link

HI,
We are running v2.4.7 and dependency chart, the issue is still present ?
The values and parameters looks ok and are corrected read from values.yaml, but when I sync it, the values applied are the default.

@crenshaw-dev
Copy link
Member

@ale-conekta I believe this issue was about values not appearing in the UI but actually applying.

If you're having an issue with values appearing in the UI but not applying, I think that's a new issue.

@ale-conekta
Copy link

@crenshaw-dev thanks you for your feedback, I will try to open an issue.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.