ArgoCD UI shows incorrect values when using ArgoCD + Helm for deployment

[iampranabroy]

Describe the bug

When deploying applications using Helm + ArgoCD and passing Helm values from ArgoCD manifest file to override the default helm values, the PARAMETERS section in the PARAMETERS tab still shows the default Helm chart values.

The Application does get created with helm values that are passed from the ArgoCD manifest file, so we are good there.
But, would like to understand if this is the default behavior of ArgoCD when put together with Helm or it should show the values that are sent from ArgoCD manifest file.

To Reproduce
Override default Helm values from ArgoCD manifest files using:

source:
    helm:
      values: |
         values...

Expected behavior
The PARAMETERS section in the PARAMETERS tab should show values that were passed from the ARgoCD manifest files. If not, the UI should indicate saying that it is default helm values.

Screenshots

Version

v2.3.3+

[fredfp]

This could be a duplicate of #9175

[crenshaw-dev]

@guitmz rightly pointed out that this has not been fixed.

The fix was for showing values from "Values Files," not from "Values." Showing the "Values" overrides in "Parameters" is still tbd.

[danielpsf]

Any updates on this?

[alexef]

Does ArgoCD auto pick a file called "values.yaml" if there?

@CzapBran Yes, but I believe this is how helm behaves, not Argo. When you specify values in the UI, they end up in a randomly generated file name so they do not override the values.yaml inside the chart.

see: https://github.com/argoproj/argo-cd/blob/master/reposerver/repository/repository.go#L858-L932 for reference (#11529)

[CzapBran]

@alexef Yup, you're right, tested it out without any file named "values.yaml" and it works as expected. I'll removed the comment as it's not relevant

[todaywasawesome]

@alexef @iampranabroy Is this PR still relevant?

[yahel2410]

Hi,
Is this still an issue?

I'm using the .argocd-source-<appName>.yaml file to override the image.tag param. But seeing the default latest tag in ArgoCD Parameters screen

ArgoCD version v2.8.4

[zmedico]

Yeah it's still an issue, I'm seeing it with v2.10.7.

[zlodes]

Spent about ~1 hour assessing what's wrong with ApplicationSet and values... 🤦🏻

v2.12.2+560953c

[andrescolodrero]

spent a day.. still happening in v.2.11, helm values in mulisource never overrides helm parameters

[lornest]

We've just starting hitting this issue in v2.11 and v2.12.5 when testing locally to see if upgrading would resolve. We switched from single source to multi source and that was when the issue started.

We're less concerned about the values being wrong in the UI (although that is a problem) and more concerned about the fact that they are wrong in the Argo Notification messages, as we rely on these for progressing builds through environments (image tag is set as a value so now the default <nil> shows in the notification message).