Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic to handle for f.Close() #10004

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 15, 2022

Add logic to handle for f.Close() in test/e2e/fixture/fixture.go
Part of issue: #9963

Signed-off-by: xin.li <xin.li@daocloud.io>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.96%. Comparing base (7d31d61) to head (a1b4e85).
Report is 2740 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10004   +/-   ##
=======================================
  Coverage   45.96%   45.96%           
=======================================
  Files         227      227           
  Lines       27276    27276           
=======================================
  Hits        12538    12538           
  Misses      13036    13036           
  Partials     1702     1702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @my-git9 !

@crenshaw-dev crenshaw-dev merged commit 8ec9ad7 into argoproj:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants