Add merge key info for smp #10107
Closed
Add merge key info for smp #10107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <zachaller@hotmail.com>
|
I've given up on doing codegen locally right, and now I just copy and paste from the failed check's diff. :-P |
|
@crenshaw-dev oh good, i'm not the only one |
|
hey, just interested if there is any progress on this PR? |
todaywasawesome
added
the
lifecycle/rotten
|
@zachaller closing it, feel free to reopen once you will continue work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds SMP info to the types that are arrays so that we can generate a proper schema for kustomize. This is related to this PR from rollouts. argoproj/argo-rollouts#2153 or https://github.com/zachaller/argo-schema-generator
Signed-off-by: zachaller zachaller@hotmail.com