Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate word in comments #10479

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.76%. Comparing base (40594cd) to head (ddf6424).
Report is 2595 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10479   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         234      234           
  Lines       28460    28460           
=======================================
  Hits        13025    13025           
  Misses      13658    13658           
  Partials     1777     1777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Abirdcfly !

LGTM.

@jannfis jannfis merged commit 43dd2b3 into argoproj:master Aug 30, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 30, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 30, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants