Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated error message to include context #11066

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

vpandeti
Copy link
Contributor

Signed-off-by: Prasad Pandeti prasad_pandeti@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Prasad Pandeti <prasad_pandeti@intuit.com>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Patch coverage has no change and project coverage change: -3.40 ⚠️

Comparison is base (038f680) 48.99% compared to head (ef0d703) 45.60%.

❗ Current head ef0d703 differs from pull request most recent head 5921134. Consider uploading reports for the commit 5921134 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11066      +/-   ##
==========================================
- Coverage   48.99%   45.60%   -3.40%     
==========================================
  Files         246      237       -9     
  Lines       42486    28914   -13572     
==========================================
- Hits        20816    13185    -7631     
+ Misses      19559    13913    -5646     
+ Partials     2111     1816     -295     
Impacted Files Coverage Δ
reposerver/cache/cache.go 60.52% <0.00%> (-0.50%) ⬇️
reposerver/repository/repository.go 61.11% <0.00%> (+0.68%) ⬆️

... and 244 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vpandeti
Copy link
Contributor Author

@crenshaw-dev Would you please review this small PR?

@fengshunli
Copy link
Member

@crenshaw-dev @alexef can be merged

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vpandeti!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 29, 2023 19:20
@crenshaw-dev crenshaw-dev merged commit bab74b5 into argoproj:master Mar 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Prasad Pandeti <prasad_pandeti@intuit.com>
Co-authored-by: Prasad Pandeti <prasad_pandeti@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants