Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unified option format #11258

Merged
merged 2 commits into from
Jun 29, 2023
Merged

fix: unified option format #11258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b84274
Unified option format
Nov 10, 2022
3475d29
Merge branch 'master' into optimize-cert-option-descriptions
pasha-codefresh Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/argocd/commands/cert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func NewCertAddTLSCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command
}
},
}
command.Flags().StringVar(&fromFile, "from", "", "read TLS certificate data from file (default is to read from stdin)")
command.Flags().StringVar(&fromFile, "from", "", "Read TLS certificate data from file (default is to read from stdin)")
command.Flags().BoolVar(&upsert, "upsert", false, "Replace existing TLS certificate if certificate is different in input")
return command
}
Expand Down Expand Up @@ -300,9 +300,9 @@ func NewCertListCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {
}

command.Flags().StringVarP(&output, "output", "o", "wide", "Output format. One of: json|yaml|wide")
command.Flags().StringVar(&sortOrder, "sort", "", "set display sort order for output format wide. One of: hostname|type")
command.Flags().StringVar(&certType, "cert-type", "", "only list certificates of given type, valid: 'ssh','https'")
command.Flags().StringVar(&hostNamePattern, "hostname-pattern", "", "only list certificates for hosts matching given glob-pattern")
command.Flags().StringVar(&sortOrder, "sort", "", "Set display sort order for output format wide. One of: hostname|type")
command.Flags().StringVar(&certType, "cert-type", "", "Only list certificates of given type, valid: 'ssh','https'")
command.Flags().StringVar(&hostNamePattern, "hostname-pattern", "", "Only list certificates for hosts matching given glob-pattern")
return command
}

Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide/commands/argocd_cert_add-tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ argocd cert add-tls SERVERNAME [flags]
### Options

```
--from string read TLS certificate data from file (default is to read from stdin)
--from string Read TLS certificate data from file (default is to read from stdin)
-h, --help help for add-tls
--upsert Replace existing TLS certificate if certificate is different in input
```
Expand Down
6 changes: 3 additions & 3 deletions docs/user-guide/commands/argocd_cert_list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ argocd cert list [flags]
### Options

```
--cert-type string only list certificates of given type, valid: 'ssh','https'
--cert-type string Only list certificates of given type, valid: 'ssh','https'
-h, --help help for list
--hostname-pattern string only list certificates for hosts matching given glob-pattern
--hostname-pattern string Only list certificates for hosts matching given glob-pattern
-o, --output string Output format. One of: json|yaml|wide (default "wide")
--sort string set display sort order for output format wide. One of: hostname|type
--sort string Set display sort order for output format wide. One of: hostname|type
```

### Options inherited from parent commands
Expand Down