Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Object options menu truncated when selected in Application Details View #11695

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

schakrad
Copy link
Contributor

…onListView.

Signed-off-by: schakradari saisindhu_chakradari@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • [x ] I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Before
Screen Shot 2022-12-13 at 5 17 26 PM

After
Screen Shot 2022-12-13 at 12 32 15 PM

…pplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
@schakrad schakrad changed the title #11602 fix : Object options menu truncated when selected in Applicati… #11602 fix:Object options menu truncated when selected in Applicati… Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b4c617) 49.02% compared to head (476ab49) 49.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11695   +/-   ##
=======================================
  Coverage   49.02%   49.03%           
=======================================
  Files         246      246           
  Lines       42519    42519           
=======================================
+ Hits        20846    20849    +3     
+ Misses      19560    19558    -2     
+ Partials     2113     2112    -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@schakrad schakrad changed the title #11602 fix:Object options menu truncated when selected in Applicati… fix- #11602 fix:Object options menu truncated when selected in Applicati… Jan 31, 2023
@schakrad schakrad changed the title fix- #11602 fix:Object options menu truncated when selected in Applicati… fix:#11602 Object options menu truncated when selected in Applicati… Jan 31, 2023
@schakrad schakrad changed the title fix:#11602 Object options menu truncated when selected in Applicati… fix: Object options menu truncated when selected in Applicati… Jan 31, 2023
@schakrad schakrad changed the title fix: Object options menu truncated when selected in Applicati… fix: Object options menu truncated when selected in Application view Jan 31, 2023
@schakrad schakrad changed the title fix: Object options menu truncated when selected in Application view fix: Object options menu truncated when selected in Application Details View Jan 31, 2023
@schakrad schakrad marked this pull request as ready for review January 31, 2023 05:19
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test lgtm!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 31, 2023 20:17
@crenshaw-dev crenshaw-dev merged commit 700a6c1 into argoproj:master Mar 31, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…stView. (argoproj#11695)

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants