Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support health check on ClusterIssuer #12000

Merged
merged 1 commit into from
May 4, 2023
Merged

feat: support health check on ClusterIssuer #12000

merged 1 commit into from
May 4, 2023

Conversation

czchen
Copy link
Contributor

@czchen czchen commented Jan 16, 2023

Signed-off-by: ChangZhuo Chen (陳昌倬) czchen@czchen.org

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@crenshaw-dev
Copy link
Member

@czchen can you check the unit test failure?

Signed-off-by: ChangZhuo Chen (陳昌倬) <czchen@czchen.org>
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d764cf7) 47.96% compared to head (90cf74f) 47.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12000   +/-   ##
=======================================
  Coverage   47.96%   47.97%           
=======================================
  Files         246      246           
  Lines       42101    42101           
=======================================
+ Hits        20194    20197    +3     
+ Misses      19892    19890    -2     
+ Partials     2015     2014    -1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czchen
Copy link
Contributor Author

czchen commented Mar 18, 2023

@crenshaw-dev fixed.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @czchen!

@crenshaw-dev crenshaw-dev merged commit 86926d7 into argoproj:master May 4, 2023
@czchen czchen deleted the feature/cert-manager branch May 5, 2023 03:24
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: ChangZhuo Chen (陳昌倬) <czchen@czchen.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants