Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changing the help message of argocd-cmp-server #12049

Merged

Conversation

Ashwin901
Copy link
Contributor

@Ashwin901 Ashwin901 commented Jan 19, 2023

Fixes #12007
Signed-off-by: Ashwin901 ashwinprasanna9@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

cmp-server

@Ashwin901 Ashwin901 changed the title fix: Changing the help message for argocd-cmp-server fix: Changing the help message of argocd-cmp-server Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 47.44% // Head: 47.41% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a9d96ab) compared to base (adc6f56).
Patch coverage: 34.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12049      +/-   ##
==========================================
- Coverage   47.44%   47.41%   -0.03%     
==========================================
  Files         245      246       +1     
  Lines       41690    41815     +125     
==========================================
+ Hits        19778    19825      +47     
- Misses      19925    19994      +69     
- Partials     1987     1996       +9     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/settings.go 67.50% <0.00%> (ø)
util/oidc/oidc.go 57.43% <0.00%> (-0.34%) ⬇️
util/oidc/provider.go 36.20% <0.00%> (-18.34%) ⬇️
util/security/jwt.go 42.10% <42.10%> (ø)
util/session/sessionmanager.go 74.74% <45.45%> (+0.83%) ⬆️
util/settings/settings.go 48.27% <54.00%> (-0.15%) ⬇️
controller/appcontroller.go 52.27% <75.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ashwin901 Ashwin901 force-pushed the change-cmpserver-help-message branch from 2ba8f1a to 350170b Compare January 25, 2023 13:47
Signed-off-by: Ashwin901 <ashwinprasanna9@gmail.com>
@Ashwin901 Ashwin901 force-pushed the change-cmpserver-help-message branch from 350170b to a9d96ab Compare January 25, 2023 14:34
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ashwin901!

@crenshaw-dev crenshaw-dev merged commit 3865171 into argoproj:master Mar 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Ashwin901 <ashwinprasanna9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor wording in argocd-cmp-server
3 participants