chore: code clean for hack known_types.go #12304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanggangtony
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12304 +/- ##
=========================================
Coverage ? 48.99%
=========================================
Files ? 246
Lines ? 42485
Branches ? 0
=========================================
Hits ? 20815
Misses ? 19559
Partials ? 2111 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Mar 29, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>
|
@crenshaw-dev |
crenshaw-dev
approved these changes
May 27, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanggang gang.yang@daocloud.io
/kind cleanup
update Deprecated codes , and other tiny codes for the if condition .
if !strings.HasPrefix(packagePath, packagePrefix) {Deprecated: Use ForCompiler, which populates a FileSet with the positions of objects created by the importer.