Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused code for admin-settings-rbac. #12312

Merged
merged 1 commit into from
Mar 29, 2023
Merged

chore: delete unused code for admin-settings-rbac. #12312

merged 1 commit into from
Mar 29, 2023

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

/kind cleanup

delete unused code for admin-settings-rbac.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (6e9f28c) 48.94% compared to head (c9d2eec) 48.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12312      +/-   ##
==========================================
- Coverage   48.94%   48.94%   -0.01%     
==========================================
  Files         246      246              
  Lines       42435    42434       -1     
==========================================
- Hits        20770    20769       -1     
  Misses      19555    19555              
  Partials     2110     2110              
Impacted Files Coverage Δ
cmd/argocd/commands/admin/settings_rbac.go 24.48% <33.33%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yanggang <gang.yang@daocloud.io>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yanggangtony!

@crenshaw-dev crenshaw-dev merged commit 8d1bcc0 into argoproj:master Mar 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: yanggang <gang.yang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants