fix: sanitize repo creds in error messages (#12309) #12320
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
wanghong230
approved these changes
Feb 7, 2023
blakepettersson
approved these changes
Feb 7, 2023
crenshaw-dev
added
cherry-pick/2.4
jannfis
reviewed
Feb 7, 2023
Codecov ReportBase: 47.62% // Head: 47.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #12320 +/- ##
==========================================
- Coverage 47.62% 47.62% -0.01%
==========================================
Files 246 246
Lines 41797 41802 +5
==========================================
Hits 19907 19907
- Misses 19897 19902 +5
Partials 1993 1993
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
removed
cherry-pick/2.4
crenshaw-dev
added a commit
that referenced
this pull request
Feb 8, 2023
* fix: sanitize repo creds in error messages (#12309) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * simplify Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comment Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * include error message Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picked onto release-2.6 for 2.6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12309