Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate message field #12477

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

usernameisnull
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 47.76% // Head: 47.71% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (26fb38b) compared to base (ba86be2).
Patch has no changes to coverable lines.

❗ Current head 26fb38b differs from pull request most recent head e48352f. Consider uploading reports for the commit e48352f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12477      +/-   ##
==========================================
- Coverage   47.76%   47.71%   -0.06%     
==========================================
  Files         246      246              
  Lines       41910    41908       -2     
==========================================
- Hits        20020    19996      -24     
- Misses      19891    19914      +23     
+ Partials     1999     1998       -1     
Impacted Files Coverage Δ
cmd/argocd/commands/applicationset.go 8.78% <0.00%> (-8.28%) ⬇️
util/webhook/webhook.go 68.28% <0.00%> (-0.11%) ⬇️
util/settings/settings.go 49.36% <0.00%> (ø)
applicationset/services/scm_provider/github.go 81.25% <0.00%> (ø)
applicationset/generators/git.go 86.93% <0.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@usernameisnull usernameisnull changed the title remove duplicate message field chore:remove duplicate message field Feb 16, 2023
@usernameisnull usernameisnull changed the title chore:remove duplicate message field chore: remove duplicate message field Feb 16, 2023
Signed-off-by: mabing <bing.ma@daocloud.io>
@usernameisnull usernameisnull force-pushed the duplicate-message-field branch from 6863d2b to 8c1a6fc Compare February 16, 2023 12:24
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @usernameisnull!

@crenshaw-dev crenshaw-dev merged commit 038f680 into argoproj:master Mar 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: mabing <bing.ma@daocloud.io>
Co-authored-by: mabing <bing.ma@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants