-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documentation to reflect the procedure on current keycloak (#12495) #12505
docs: update documentation to reflect the procedure on current keycloak (#12495) #12505
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12505 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44653 44653
=======================================
Hits 22222 22222
Misses 20248 20248
Partials 2183 2183 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Would you mind running the images through squoosh.app or similar? Trying to keep repo size down. :-)
versions Signed-off-by: Max Mueller <mmueller@anynines.com>
925b23e
to
75530b8
Compare
@crenshaw-dev I was able to reduce the image size to ~24-26% of the previous ones. Should be okay now. |
@crenshaw-dev are there any more issues with this PR? Dhould I maybe sync it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
@mmueller-a9s apologies for the delay, and thanks for the contribution! :-) |
…ak (argoproj#12505) versions Signed-off-by: Max Mueller <mmueller@anynines.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…ak (argoproj#12505) versions Signed-off-by: Max Mueller <mmueller@anynines.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Closes #12495
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: