Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Health Checks for IngressController resources #12776

Merged

Conversation

jacksgt
Copy link
Contributor

@jacksgt jacksgt commented Mar 9, 2023

This patch adds Argo CD healths check for operator.openshift.io/IngressController CRDs

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jacksgt jacksgt force-pushed the ingresscontroller-healthchecks branch from fa08208 to 76f2a39 Compare March 9, 2023 12:50
Signed-off-by: Jack Henschel <jack.henschel@cern.ch>
@jacksgt jacksgt force-pushed the ingresscontroller-healthchecks branch from 76f2a39 to df2118b Compare March 9, 2023 13:10
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@558140f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12776   +/-   ##
=========================================
  Coverage          ?   47.77%           
=========================================
  Files             ?      246           
  Lines             ?    41985           
  Branches          ?        0           
=========================================
  Hits              ?    20057           
  Misses            ?    19929           
  Partials          ?     1999           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacksgt
Copy link
Contributor Author

jacksgt commented Mar 16, 2023

Could someone take a look when they have the moment?
@alexmt @reginapizza @zachaller

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jacksgt!

@crenshaw-dev crenshaw-dev merged commit 182eb05 into argoproj:master May 29, 2023
@jacksgt jacksgt deleted the ingresscontroller-healthchecks branch May 30, 2023 16:19
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants