docs: nginx passthrough secret as argocd-server-tls #12921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdg-journeyfront
changed the title
morey-tech
approved these changes
Mar 21, 2023
As documented in tls.md § "TLS certificates used by argocd-server", the secret that should be modified by cert-manager is not `argocd-server` but `argocd-server-tls` should be created instead. The ingress-nginx controller doesn't like using a secret of `type: Opaque`. Signed-off-by: Josh Gardner <111776680+jdg-journeyfront@users.noreply.github.com>
jdg-journeyfront
force-pushed
the
update-doc-nginx-passthrough-secret
branch
from
ad6275e to
7a738e1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12921 +/- ##
=======================================
Coverage 48.94% 48.94%
=======================================
Files 246 246
Lines 42435 42435
=======================================
Hits 20770 20770
Misses 19555 19555
Partials 2110 2110 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
crenshaw-dev
changed the title
jannfis
approved these changes
May 3, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
As documented in tls.md § "TLS certificates used by argocd-server", the secret that should be modified by cert-manager is not `argocd-server` but `argocd-server-tls` should be created instead. The ingress-nginx controller doesn't like using a secret of `type: Opaque`. Signed-off-by: Josh Gardner <111776680+jdg-journeyfront@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in tls.md § "TLS certificates used by argocd-server", the secret that should be modified by cert-manager is not
argocd-serverbutargocd-server-tlsshould be created instead.The ingress-nginx controller doesn't like using a secret of
type: Opaque.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.