Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update health documentation #12996

Merged
merged 1 commit into from
May 29, 2023
Merged

feat: Update health documentation #12996

merged 1 commit into from
May 29, 2023

Conversation

pierreyves-lebrun
Copy link
Contributor

@pierreyves-lebrun pierreyves-lebrun commented Mar 24, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

This PR update the health documentation regarding how to enable LUA standard library for custom health checks

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (4def3b8) 49.09% compared to head (789591e) 48.93%.

❗ Current head 789591e differs from pull request most recent head 1542c57. Consider uploading reports for the commit 1542c57 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12996      +/-   ##
==========================================
- Coverage   49.09%   48.93%   -0.16%     
==========================================
  Files         249      246       -3     
  Lines       43182    42429     -753     
==========================================
- Hits        21199    20764     -435     
+ Misses      19864    19555     -309     
+ Partials     2119     2110       -9     

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev requested a review from reggie-k May 28, 2023 01:30
Signed-off-by: Pierre Lebrun <pierreyves.lebrun@gmail.com>
@crenshaw-dev crenshaw-dev merged commit 9fa2901 into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Pierre Lebrun <pierreyves.lebrun@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Pierre Lebrun <pierreyves.lebrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants