Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add wildcard filtering to the name search field (#11781) #13022

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

ItsKev
Copy link
Contributor

@ItsKev ItsKev commented Mar 27, 2023

Closes #11781

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@ItsKev ItsKev force-pushed the add-wildcard-filter-to-name-filters branch 2 times, most recently from fb42426 to 2087ec0 Compare March 27, 2023 21:22
Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
@ItsKev ItsKev force-pushed the add-wildcard-filter-to-name-filters branch from 2087ec0 to f5ee5d2 Compare March 28, 2023 05:00
@ItsKev
Copy link
Contributor Author

ItsKev commented Mar 28, 2023

This is my first time contributing to Argo CD.

I've implemented the feature described in the #11781 issue but did not find any tests covering this specific class. How would I proceed here when I wanted to add tests to the method I touched? Any hints or clues would be helpful.

@ItsKev ItsKev marked this pull request as ready for review March 28, 2023 05:54
@crenshaw-dev
Copy link
Member

@ItsKev thanks for the PR!

Our frontend testing is relatively light. I've requested reviews from a couple of our frontend experts.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rbreeze rbreeze merged commit 86bdc17 into argoproj:master Mar 28, 2023
@ItsKev ItsKev deleted the add-wildcard-filter-to-name-filters branch April 1, 2023 09:56
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard filter in UI
3 participants