-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display error msg when live state is empty #13031
fix: Display error msg when live state is empty #13031
Conversation
d30fafe
to
fce426e
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13031 +/- ##
==========================================
- Coverage 49.06% 49.05% -0.01%
==========================================
Files 246 246
Lines 42561 42561
==========================================
- Hits 20881 20878 -3
- Misses 19565 19567 +2
- Partials 2115 2116 +1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ui/src/app/applications/components/application-node-info/application-node-info.scss
Outdated
Show resolved
Hide resolved
fce426e
to
7900853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cool, it displays the error msg, thanks for providing the screenshot as well |
/cherry-pick release-2.7 |
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
262e18d
to
9823896
Compare
Testing locally I get this error:
Test app: apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: test
spec:
destination:
namespace: default
server: https://kubernetes.default.svc
project: default
source:
path: kustomize-guestbook
repoURL: https://github.com/crenshaw-dev/argocd-example-apps
targetRevision: bad-api-version |
Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
@crenshaw-dev I successfully created and sync the application using the manifest you provide and I couldn't reproduce the error locally, the UI message shows up fine (error msg shows in the
|
I was able to create the app from the below command. It's OutOfSync but as expected to test the PR I think.
|
Cherry-pick failed with |
* fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
* fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: disply error when live state is empty Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: asingh <11219262+ashutosh16@users.noreply.github.com>
This PR displays the error message in the live state editor when argocd failed to fetch the resource manifest due to a change in the API version. This issue occurred when k8s cluster is upgraded to 1.22 and the API networking.k8s.io/v1beta1 is deprecated. ArgoCD is unable to fetch the live state of the resource and displays the {} state. In this PR, the user will see relevant information regarding the correct API version to use