Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove invalid err check #13040

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

kkzhui
Copy link
Contributor

@kkzhui kkzhui commented Mar 29, 2023

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
remove invalid err check

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Signed-off-by: zenghui.li [zenghui.li@daocloud.io]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

kkzhui added 2 commits March 29, 2023 19:40
remove invalid err check

Signed-off-by: kkzhui <40911565+kkzhui@users.noreply.github.com>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kkzhui!

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@bab74b5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #13040   +/-   ##
=========================================
  Coverage          ?   48.98%           
=========================================
  Files             ?      246           
  Lines             ?    42484           
  Branches          ?        0           
=========================================
  Hits              ?    20812           
  Misses            ?    19560           
  Partials          ?     2112           
Impacted Files Coverage Δ
cmd/argocd/commands/admin/backup.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit b44c301 into argoproj:master Mar 30, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
remove invalid err check

Signed-off-by: kkzhui <40911565+kkzhui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants