Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set arrow into negative space in pod-terminal-viewer (fix for issue #12063) #13060

Merged
merged 2 commits into from
May 29, 2023

Conversation

nickorlow
Copy link
Contributor

@nickorlow nickorlow commented Mar 30, 2023

This moves an element in the UI for choosing a container within a pod a bit to the left as to not offset the name of the container.

Before:
image

After:
image

FIXES #12063


Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [N/A] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • [N/A] I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • [N/A ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@nickorlow nickorlow changed the title Set arrow into negative space in pod-terminal-viewer (fix for issue #12063) fix: Set arrow into negative space in pod-terminal-viewer (fix for issue #12063) Mar 30, 2023
Signed-off-by: Nicholas Orlowsky <nickorlow@nickorlow.com>
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 80.88% and project coverage change: +0.08 🎉

Comparison is base (5662367) 48.98% compared to head (a081170) 49.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13060      +/-   ##
==========================================
+ Coverage   48.98%   49.06%   +0.08%     
==========================================
  Files         249      249              
  Lines       43066    43123      +57     
==========================================
+ Hits        21094    21159      +65     
+ Misses      19864    19853      -11     
- Partials     2108     2111       +3     
Impacted Files Coverage Δ
util/git/client.go 50.00% <37.50%> (ø)
server/cluster/cluster.go 50.13% <85.71%> (+10.20%) ⬆️
controller/appcontroller.go 53.38% <100.00%> (+0.22%) ⬆️
pkg/apis/application/v1alpha1/types.go 59.68% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 834d01e into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…oj#13060)

Signed-off-by: Nicholas Orlowsky <nickorlow@nickorlow.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…oj#13060)

Signed-off-by: Nicholas Orlowsky <nickorlow@nickorlow.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow for currently selected container should not indent container name
4 participants