-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MariaDB CRD health checks #13143
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13143 +/- ##
==========================================
+ Coverage 49.01% 49.14% +0.12%
==========================================
Files 247 248 +1
Lines 42685 42891 +206
==========================================
+ Hits 20924 21079 +155
- Misses 19645 19693 +48
- Partials 2116 2119 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Sirvent <vivi@vivide.re>
Could we get a review here please? 👀 Thanks again for your contributions @Vidalee ! mariadb-operator is growing in adoption and it would be awesome to integrate with ArgoCD, let us now if you need anything else! |
Signed-off-by: Thomas Sirvent <vivi@vivide.re>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm thx for providing extra knowledge to argocd for mariadb :)
Signed-off-by: Thomas Sirvent <vivi@vivide.re>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Vidalee!
* feat: add MariaDB CRD health checks Signed-off-by: Thomas Sirvent <vivi@vivide.re> * feat: set Degraded health on MariaDB CRD error Signed-off-by: Thomas Sirvent <vivi@vivide.re> * style: add missing newline Signed-off-by: Thomas Sirvent <vivi@vivide.re> --------- Signed-off-by: Thomas Sirvent <vivi@vivide.re>
The PR adds health check for MariaDB CRD which is used by mariadb-operator
All the possible conditions states are handled (see the controller source code)
Fixes the issue where the MariaDB CRD is Healthy and ready but the StatefulSet is still deploying the server pod or a backup is currently being restored.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Note: No issues related