Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add last sync field to application tile #13184

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

reginapizza
Copy link
Contributor

Adds "Last Sync" data to application tiles on list page.
Fixes #13141.

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh16
Copy link
Contributor

Verified the changes in my local
Screenshot 2023-04-11 at 2 16 57 PM

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze
Copy link
Member

rbreeze commented Apr 13, 2023

@reginapizza heads up, looks like CI is failing due to a linter issue

@rbreeze rbreeze enabled auto-merge (squash) April 13, 2023 15:11
auto-merge was automatically disabled April 13, 2023 16:09

Head branch was pushed to by a user without write access

@reginapizza reginapizza force-pushed the issue-13141 branch 2 times, most recently from ad11174 to a5ff5f5 Compare April 18, 2023 15:56
@reginapizza reginapizza reopened this Apr 18, 2023
Signed-off-by: Regina Scott <rescott@redhat.com>
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3ad4bf4) 49.06% compared to head (ee55924) 49.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13184      +/-   ##
==========================================
- Coverage   49.06%   49.06%   -0.01%     
==========================================
  Files         246      246              
  Lines       42587    42587              
==========================================
- Hits        20897    20894       -3     
- Misses      19574    19576       +2     
- Partials     2116     2117       +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexmt alexmt merged commit daae5ef into argoproj:master Apr 26, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Regina Scott <rescott@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Sync date to application tile
5 participants