Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Argo CD Core documentation #13225

Merged
merged 8 commits into from
Apr 15, 2023
Merged

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Apr 13, 2023

Add Argo CD Core documentation

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9b53eeb) 49.05% compared to head (71caa32) 49.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13225   +/-   ##
=======================================
  Coverage   49.05%   49.05%           
=======================================
  Files         246      246           
  Lines       42569    42575    +6     
=======================================
+ Hits        20882    20885    +3     
- Misses      19572    19574    +2     
- Partials     2115     2116    +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

leoluz added 3 commits April 14, 2023 10:40
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Copy link
Contributor

@morey-tech morey-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited to see more documentation around the core installation! I've left a few comments with non-blocking nits.

docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/installation.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested a review from morey-tech April 14, 2023 15:43
@leoluz
Copy link
Collaborator Author

leoluz commented Apr 14, 2023

Thank you @morey-tech for your review. All valuable suggestions!
Addressed all comments.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
docs/operator-manual/core.md Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
docs/operator-manual/core.md Outdated Show resolved Hide resolved
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested a review from crenshaw-dev April 14, 2023 19:40
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz enabled auto-merge (squash) April 14, 2023 20:04
@leoluz leoluz disabled auto-merge April 14, 2023 20:22
@leoluz leoluz enabled auto-merge (squash) April 14, 2023 20:23
@leoluz leoluz merged commit c7f8ddd into argoproj:master Apr 15, 2023
@leoluz leoluz deleted the doc.argocd.core branch April 16, 2023 07:57
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* docs: Add Argo CD Core documentation

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* docs: Add Argo CD usage to the docs

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* docs: add Redis details in Argo CD Core doc

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* docs: minor fix

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* minor fix

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* minor fix

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

---------

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants