fix: list manually provided external urls before generated ones #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick <nkkowa@gmail.com>
nkkowa
force-pushed
the
fix/external-url-order
branch
from
a6a3ce7 to
85b8f29
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #13296 +/- ##
==========================================
+ Coverage 49.68% 49.70% +0.01%
==========================================
Files 267 267
Lines 46362 46374 +12
==========================================
+ Hits 23036 23051 +15
+ Misses 21067 21063 -4
- Partials 2259 2260 +1
☔ View full report in Codecov by Sentry. |
harshsingh32
approved these changes
Apr 22, 2023
ishitasequeira
approved these changes
Apr 30, 2023
ymktmk
pushed a commit
to ymktmk/argo-cd
that referenced
this pull request
Oct 29, 2023
…proj#13296) Signed-off-by: Nick <nkkowa@gmail.com>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…proj#13296) Signed-off-by: Nick <nkkowa@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…proj#13296) Signed-off-by: Nick <nkkowa@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…proj#13296) Signed-off-by: Nick <nkkowa@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…proj#13296) Signed-off-by: Nick <nkkowa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures links that are manually added with the
link.argocd.argoproj.ioannotation take priority over generated links.Rationale
If an ingress resource should provide HTTPS links but lacks the
tlssection as described in #8021, users can specify the correct link manually via the annotation. However, this is added after the auto-generated one, causing the default action in the UI to still provide the incorrect URL. You can still access the additional link via the drop-down, though this is counter-intuitive and prevents this annotation from being usable to correct the default behaviour of the link.Checklist:
Please see Contribution FAQs if you have questions about your pull-request.