Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set readOnlyRootFilesystem to true for redis and ha-proxy (#13315) #13316

Merged
merged 1 commit into from
May 29, 2023

Conversation

jemag
Copy link
Contributor

@jemag jemag commented Apr 21, 2023

Fixes #13315

This PR sets readOnlyRootFilesystem to true for redis and ha-proxy thus improving the default security configuration in line with other workloads.

There does not seem to be any impact to those containers, although I would love for others to test it as well.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e154b0) 49.01% compared to head (461d7fd) 49.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13316   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files         247      247           
  Lines       42685    42685           
=======================================
+ Hits        20921    20924    +3     
+ Misses      19647    19645    -2     
+ Partials     2117     2116    -1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test with kind checks out. If there are issues, we'll catch them in RCs. :-) Thanks @jemag!

@crenshaw-dev crenshaw-dev merged commit 228310d into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…roj#13316)

Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…roj#13316)

Signed-off-by: Alexandre Desjardins <alexandre.bd@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use readOnlyRootFilesystem: true for redis and ha-proxy
2 participants