-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add GoTo Financial ArgoCD user #13317
Conversation
Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13317 +/- ##
==========================================
+ Coverage 49.01% 49.05% +0.04%
==========================================
Files 247 249 +2
Lines 42685 43119 +434
==========================================
+ Hits 20921 21152 +231
- Misses 19647 19855 +208
+ Partials 2117 2112 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nitpicks. Thanks @zufardhiyaulhaq!
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zufardhiyaulhaq!
* add GoTo Financial ArgoCD user Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com> * alphabetical order Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* add GoTo Financial ArgoCD user Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com> * alphabetical order Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
We from GoTo Financial heavily use ArgoCD as our GitOps platform.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.