-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add additional field to set Extra Build Information while building argo-cd by vendors #13324
chore: Add additional field to set Extra Build Information while building argo-cd by vendors #13324
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13324 +/- ##
==========================================
- Coverage 49.02% 49.01% -0.01%
==========================================
Files 247 247
Lines 42694 42700 +6
==========================================
Hits 20930 20930
- Misses 19647 19653 +6
Partials 2117 2117
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some nits here
…ocd by vendors Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
…ding argo-cd by vendors (argoproj#13324) * Add additonal field to set Extra Build Information while building argocd by vendors Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Include spaces in extra build info Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
The PR adds a new field
ExtraBuildInfo
to the version information. This field allows vendors to pass in additional information while building argo-cd image needed by them.E.g.:
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: