Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Page header and toolbar in system extensions #13451

Merged
merged 3 commits into from
May 14, 2023
Merged

feat: Page header and toolbar in system extensions #13451

merged 3 commits into from
May 14, 2023

Conversation

egmar
Copy link
Contributor

@egmar egmar commented May 4, 2023 •
edited
Loading

This PR:

Adds header and toolbar visible in all other pages to the pages created using system extensions. This enhances the feature merged in #10758

image

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@egmar
Wrapped system extension component into Page
3005209 
Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>
@egmar egmar marked this pull request as draft May 4, 2023 14:46
@egmar egmar marked this pull request as ready for review May 4, 2023 14:53
@egmar
Added missing semicolon
2571cee 
Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>
@alexmt alexmt requested a review from rbreeze May 4, 2023 19:37
@alexmt
Copy link
Collaborator

alexmt commented May 4, 2023

It makes sense to me. @rbreeze can you take a look please?

@rbreeze
Copy link
Member

rbreeze commented May 5, 2023

@alexmt Sure thing!

@egmar
Empty commit to trigger checks
c4d2f32 
Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>
rbreeze
rbreeze approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit 7825821 into argoproj:master May 14, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@egmar
feat: Page header and toolbar in system extensions (argoproj#13451)
8f591e2 
* Wrapped system extension component into Page

Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>

* Added missing semicolon

Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>

* Empty commit to trigger checks

Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>

---------

Signed-off-by: Egor Margineanu <egmar@users.noreply.github.com>
@david-wu-octopus david-wu-octopus mentioned this pull request May 14, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egmar @alexmt @rbreeze