-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appset): Add argocd.argoproj.io/application-set-name to rendered appset applications #13456
Conversation
864d800
to
44b0708
Compare
38c6be3
to
820f308
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13456 +/- ##
==========================================
- Coverage 49.15% 49.07% -0.09%
==========================================
Files 248 250 +2
Lines 42902 43248 +346
==========================================
+ Hits 21090 21225 +135
- Misses 19694 19892 +198
- Partials 2118 2131 +13
☔ View full report in Codecov by Sentry. |
d97acb0
to
45b6bd8
Compare
Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
1122de4
to
430ffc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable for me at least, at $dayjob
we currently work around this by setting our own custom label. Let's see if my sentiment is shared by the others 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MeNsaaH!
Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
… appset applications (argoproj#13456) * Add app.kubernetes.io/appset-instance to rendered applications Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * initialize labels map if nil Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Updated label ->argocd.argoproj.io/application-set-name Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> --------- Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
This PR introduced a regression: #15282 I don't think forcing a custom label for an application was a good idea in the first place, honestly:
A better approach is to add wanna-be generated application names into ApplicationSet resource itself. |
… appset applications (argoproj#13456) * Add app.kubernetes.io/appset-instance to rendered applications Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * initialize labels map if nil Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Fix tests Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> * Updated label ->argocd.argoproj.io/application-set-name Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com> --------- Signed-off-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.
As part of #13309, this PR adds a new label to all applications generated by appsets. This way, we can list all the apps belonging to an appset by running
closes #13309