-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): use react link to route to relative deep-link path #13529
Conversation
e82d768
to
7cec5f2
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
97d44f0
to
45f01ea
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13529 +/- ##
=======================================
Coverage 49.22% 49.22%
=======================================
Files 248 248
Lines 42830 42830
=======================================
Hits 21084 21084
Misses 19648 19648
Partials 2098 2098 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but will get @rbreeze to approve it too before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…#13529) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
…#13529) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.