Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests to validate helm ranges (#4047) #13662

Merged
merged 2 commits into from
May 28, 2023

Conversation

blentz
Copy link
Contributor

@blentz blentz commented May 19, 2023

This adds unit test to validate that helm version ranges are properly supported.

Fixes #4047

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ x] The title of the PR conforms to the Toolchain Guide
  • [x ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [n/a ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ no] Does this PR require documentation updates?
  • [ n/a] I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • [x ] I have signed off all my commits as required by DCO
  • [x ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • [x ] My new feature complies with the feature status guidelines.
  • [x ] I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@blentz blentz force-pushed the add-semver-tests branch 2 times, most recently from efa547c to d510a96 Compare May 19, 2023 15:32
Signed-off-by: Brett Lentz <brett.lentz@analog.com>
@blentz blentz force-pushed the add-semver-tests branch from d510a96 to 2731851 Compare May 19, 2023 15:33
@crenshaw-dev crenshaw-dev changed the title chore: add tests to validate helm ranges, Fixes #4047 test: add tests to validate helm ranges (#4047) May 27, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 27, 2023 21:46
@crenshaw-dev crenshaw-dev merged commit 488583f into argoproj:master May 28, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Brett Lentz <brett.lentz@analog.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Brett Lentz <brett.lentz@analog.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComparisonError when creating an app with version range
2 participants