Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in manifest #13677

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: typo in manifest #13677

merged 1 commit into from
May 22, 2023

Conversation

wim-de-groot
Copy link
Contributor

This PR wil fix a typo in the manifest file manifests/crds/application-crd.yaml.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87a7dff) 49.17% compared to head (6e6e99f) 49.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13677   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         248      248           
  Lines       42871    42871           
=======================================
  Hits        21083    21083           
  Misses      19687    19687           
  Partials     2101     2101           
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 59.55% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexmt
Copy link
Collaborator

alexmt commented May 20, 2023

Thank you @wim-de-groot !

the manifests/crds/application-crd.yaml is auto generated. Please update https://github.com/argoproj/argo-cd/blob/87a7dff4585c514304c9e46cdbe8ad20051c935f/pkg/apis/application/v1alpha1/types.go#LL1155C1-L1155C1 instead and run ‘make codegen’

Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
@wim-de-groot
Copy link
Contributor Author

Thank you @wim-de-groot !

the manifests/crds/application-crd.yaml is auto generated. Please update https://github.com/argoproj/argo-cd/blob/87a7dff4585c514304c9e46cdbe8ad20051c935f/pkg/apis/application/v1alpha1/types.go#LL1155C1-L1155C1 instead and run ‘make codegen’

Sorry @alexmt, I should have caught that in the first place. I have replaced my fix with your recommendation.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@alexmt alexmt enabled auto-merge (squash) May 22, 2023 17:44
@alexmt alexmt merged commit babe357 into argoproj:master May 22, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
Co-authored-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
Co-authored-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants