-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in manifest #13677
fix: typo in manifest #13677
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13677 +/- ##
=======================================
Coverage 49.17% 49.17%
=======================================
Files 248 248
Lines 42871 42871
=======================================
Hits 21083 21083
Misses 19687 19687
Partials 2101 2101
☔ View full report in Codecov by Sentry. |
Thank you @wim-de-groot ! the manifests/crds/application-crd.yaml is auto generated. Please update https://github.com/argoproj/argo-cd/blob/87a7dff4585c514304c9e46cdbe8ad20051c935f/pkg/apis/application/v1alpha1/types.go#LL1155C1-L1155C1 instead and run ‘make codegen’ |
Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
Sorry @alexmt, I should have caught that in the first place. I have replaced my fix with your recommendation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com> Co-authored-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
Signed-off-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com> Co-authored-by: Wim de Groot <34519486+degrootwim@users.noreply.github.com>
This PR wil fix a typo in the manifest file manifests/crds/application-crd.yaml.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.