Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up repeated package import #13685

Merged
merged 2 commits into from
May 28, 2023

Conversation

Fish-pro
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Fixes: Part of #12430

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 73.33% and project coverage change: +0.07 🎉

Comparison is base (5662367) 48.98% compared to head (7abd916) 49.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13685      +/-   ##
==========================================
+ Coverage   48.98%   49.05%   +0.07%     
==========================================
  Files         249      249              
  Lines       43066    43122      +56     
==========================================
+ Hits        21094    21155      +61     
+ Misses      19864    19855       -9     
- Partials     2108     2112       +4     
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 21.80% <0.00%> (ø)
cmd/argocd/commands/project.go 0.00% <0.00%> (ø)
util/git/client.go 50.00% <37.50%> (ø)
server/cluster/cluster.go 50.13% <85.71%> (+10.20%) ⬆️
cmd/argocd/commands/initialize/cmd.go 31.25% <100.00%> (ø)
pkg/apis/application/v1alpha1/types.go 59.68% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev merged commit 3b369ea into argoproj:master May 28, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants