-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Stop using the deprecated url format for gitlab instances #13687
fix(ui): Stop using the deprecated url format for gitlab instances #13687
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13687 +/- ##
=======================================
Coverage 49.17% 49.18%
=======================================
Files 248 248
Lines 42874 42874
=======================================
+ Hits 21083 21086 +3
+ Misses 19689 19687 -2
+ Partials 2102 2101 -1 ☔ View full report in Codecov by Sentry. |
a9a438c
to
b4391c9
Compare
The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
8e0d937
to
0ed4d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tete17!
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
/cherry-pick release-2.5 |
…13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Cherry-pick failed with |
Cherry-pick failed with |
…13687) (#13767) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed * docs: Add Urbantz to the list of organizations using argo-cd --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> Co-authored-by: Tete17 <miguel_tete17@hotmail.com>
Hey @crenshaw-dev thanks for the review. Do you want me to fix the merge conflicts on the 2.5 & 2.6 branhces? |
That would be great, thanks! You can just open PRs against those branches directly. |
…rgoproj#13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> (cherry picked from commit 5662367) Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
…rgoproj#13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> (cherry picked from commit 5662367) Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
…13687) (#13796) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed * docs: Add Urbantz to the list of organizations using argo-cd --------- (cherry picked from commit 5662367) Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
…13687) (#13797) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed * docs: Add Urbantz to the list of organizations using argo-cd --------- (cherry picked from commit 5662367) Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
…rgoproj#13687) (argoproj#13767) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed * docs: Add Urbantz to the list of organizations using argo-cd --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> Co-authored-by: Tete17 <miguel_tete17@hotmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…rgoproj#13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
…rgoproj#13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid.
Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.