fix: Disable keep alives for helm https connections (#13468)

[mkekeberg]

Fixes #13468

Like for git (#3531), it seems that we don't re-use the connection. Keeping them alive only ends up with many stale http connections after a while, like the issue mentions.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +49.18 🎉

Comparison is base (b44c805) 0.00% compared to head (8c1645a) 49.18%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #13695       +/-   ##
===========================================
+ Coverage        0   49.18%   +49.18%     
===========================================
  Files           0      248      +248     
  Lines           0    42873    +42873     
===========================================
+ Hits            0    21085    +21085     
- Misses          0    19687    +19687     
- Partials        0     2101     +2101     

Impacted Files	Coverage Δ
util/helm/client.go	50.65% <100.00%> (ø)

... and 247 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[crenshaw-dev]

LGTM. Thanks, @mkekeberg!

[crenshaw-dev]

/cherry-pick release-2.7

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 5d80789a26427ac95c02c8477b1b45d03a822c89 into temp-cherry-pick-367e15-release-2.7

[crenshaw-dev]

/cherry-pick release-2.6

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 5d80789a26427ac95c02c8477b1b45d03a822c89 into temp-cherry-pick-367e15-release-2.6

[crenshaw-dev]

/cherry-pick release-2.5

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 5d80789a26427ac95c02c8477b1b45d03a822c89 into temp-cherry-pick-367e15-release-2.5

[crenshaw-dev]

@mkekeberg would you mind opening cherry-pick PRs against the release-2.5, release-2.6, and release-2.7 branches? The bot is finicky.

[mkekeberg]

@crenshaw-dev , did that in my latest PRs 🙂
#13847
#13848
#13849

Got some conflicts when cherry picking. Might be that there is more changes that should have gone into them before my change.

[sastorsl]

@crenshaw-dev is there anything left out here to get these fixes into a release?
@mkekeberg ?

[mkekeberg]

@sastorsl , I created the "cherry pick" PRs for specific releases. Seems like nothing ever happened on those:
#13849
#13848
#13847

If the build issues on those important, I have no way of knowing. No reply from any maintainers on this project. Release-branches in the dozens like this is always tedious...

[crenshaw-dev]

Apologies for the slow responses! Merged for 2.7 and 2.6. Skipping 2.5 since it went EOL.

@sastorsl this change is already in 2.8.0. It will be in 2.7.13 and 2.6.14 when we cut those.