fix(appset): return error on invalid annotations (#13730) #13743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13730.
Basically, when we run into a fatal error while trying to manipulate annotations or labels, return that error, instead of silently ignoring it as described in the linked issue. For cases where we were already ignoring errors at a higher level, I kept ignoring them, but I tried to abort in cases where it is important for the returned value to be correct. Added unit tests to cover the error cases.
Checklist:
Does this PR require documentation updates?Optional. My organization is added to USERS.md.