Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add chainnodes to users #13754

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

koraykoska
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Koray Koska <11356621+koraykoska@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b6db057) 49.17% compared to head (d5f931c) 49.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13754   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files         248      248           
  Lines       42874    42874           
=======================================
  Hits        21083    21083           
  Misses      19689    19689           
  Partials     2102     2102           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 26, 2023 17:06
@crenshaw-dev crenshaw-dev merged commit 4ce4885 into argoproj:master May 26, 2023
@koraykoska koraykoska deleted the patch-1 branch May 26, 2023 17:25
@koraykoska koraykoska restored the patch-1 branch May 26, 2023 17:26
@koraykoska koraykoska deleted the patch-1 branch May 26, 2023 17:26
@koraykoska koraykoska restored the patch-1 branch May 26, 2023 17:26
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Koray Koska <11356621+koraykoska@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Koray Koska <11356621+koraykoska@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants